[4.3] HELP-16635: deduct tokens on all API requests #6628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each time an API request is made, deduct the token cost from the associated bucket. As part of the changes, some property tests needed updating because they exceed the token bucket. These tests disable the cost while they run and replace the prior value when they end. Another issue resolved is that bindings in blackhole, when using the kz_hooks facility, were done asynchronously. This meant that a speedy response to the websocket client followed by a generated event could occur faster than the kz_hook listener could bind its AMQP queue to the new binding. The blackhole response to a subscription now blocks until the AMQP queue is established.
jamesaimonetti
force-pushed
the
HELP-16635-4.3
branch
from
4d04be9
to
085c50f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time an API request is made, deduct the token cost
from the associated bucket.