4.3.141

Changes for 4.3.141

Changes to branch 4.3 after version 4.3.140.

Commits

• PISTON-221: only record in ACDc once per call - by Daniel Finke

  • prevent multiple overlapping recordings if caller re-enters a queue

• invalidate ci cache keys because images are updated - by iceHESS

• Fix to remove concatenated media names - by Kevin D

• KTEL-10: Replace colons by dashes on fax attachments names - by Harenson Henao

  5.x: 2600hz/kazoo-teletype#22

  When teletype sends a fax attachment, its name includes a time format that includes colons. Colons are not allowed characters for filenames in Windows and so many SMTP relays and mail servers will auto-correct the colon to a dash or underscore character. However, if the end user's server does not correct this, the resulting attachment is unopenable on Windows.

• PISTON-1267 add a handler for action 'move' to channel's crossbar API - by Alexey Khabulyak

  Add ability to move a call(call-flipping) via crossbar API

  kazoo5 PR: 2600hz/kazoo-crossbar#203

• FORUM-11759: Check for ID on req data - by James Aimonetti

  Test creating a document with ID on the request data.

• PISTON-973: big acdc_queue_manager refactor + queue manager diag tool - by Daniel Finke

  • rename some queue manager funs and call/cast messages for clarity

  • refactor agent ID list and count funs

  • replace ss_size

  • big refactor of update_strategy_with_agent

  • diagnostics launcher funs

  • diagnostics receiver attachment to queue manager

  • ?DIAG macro and payload transformation

  • create acdc_queue_manager_diag_sup

  • update unit tests

• Skip adding preflow on transfers - by James Aimonetti

  When transferring a call, don't prepend a preflow.

  Previously, preflows were prepended to all callflows when present. If

  a preflow defined a TTS like "Welcome to Company X", the caller would

  hear the TTS on call connection and, if transferred to a parking slot

  via *31 (for instance), would hear the preflow TTS again before

  hearing hold music.

  Backport of 2600hz/kazoo-callflow#77

• KZOO-190: Fix wave (wav) voicemail recordings transcription - by Harenson Henao

• PISTON-1082: Crossbar validation errors with the same top level key will no longer overwrite each other but instead will now merge the keys where possible - by Ben Bradford

  Kazoo 5pr: 2600hz/kazoo-crossbar#140

  When CB builds the error response from multiple validation errors it would do a top level merge only resulting in errors regularly overwriting each other in the response.

  EG:

  Take the error list below

  
  [{<<"numbers">>,<<"type">>,
  
  {[{<<"message">>,<<"Value did not match type(s): array">>},
  
  {<<"target">>,<<"array">>},
  
  {<<"value">>,<<"12345">>}]}},
  
  {<<"numbers">>,<<"required">>,
  
  {[{<<"message">>,
  
  <<"Callflows must be assigned at least one number or pattern">>}]}}]
  
  

  With the current merge CB would return:

  
  {[{<<"numbers">>,
  
  {[{<<"required">>,
  
  {[{<<"message">>,
  
  <<"Callflows must be assigned at least one number or pattern">>}]}}]}}]}
  
  

  With this solution, CB will respond with:

  
  {[{<<"numbers">>,
  
  {[{<<"type">>,
  
  {[{<<"value">>,<<"12345">>},
  
  {<<"target">>,<<"array">>},
  
  {<<"message">>,<<"Value did not match type(s): array">>}]}},
  
  {<<"required">>,
  
  {[{<<"message">>,
  
  <<"Callflows must be assigned at least one number or pattern">>}]}}]}}]}
  
  

  This still does not handle the the case where the keys exactly match but the only way to do this would be to change the response type of the error to an array (Breaking change) but maybe its worth considering for a future version.

  
  {
  
  "numbers": {
  
  "unique": [
  
  {
  
  "value": "12345",
  
  "message": "number is not unique"
  
  },
  
  {
  
  "value": "54321",
  
  "message": "number is not unique"
  
  }
  
  ]
  
  }
  
  }
  
  

• KZOO-179: add 988 as emergency classifier - by holy-batman

• KZOO-185: increase stop recording expiration timer - by iceHESS

  It has been observed the timer for expiration timer while waiting to receive

  RECORD_STOP event could timed out sooner than receiving that event. Increasing

  this timer to allow more time for the event to arrive so the recording can

  properly stored.

• Included options in the record call documentation that indicate a record call callflow module with an empty URL can use the storage plan for an account to store the recorded call - by sjking-ooma

  closes KAZOO-6141.

• PISTON-1184: Correctly escape and wrap values when passing to FS to prevent special characters from causing issues - by Ben Bradford