Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to VICTOR home page #26

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

volcanocyber
Copy link

No description provided.

@sgibson91 sgibson91 changed the base branch from master to victor September 1, 2023 10:26
@sgibson91 sgibson91 merged commit f250277 into 2i2c-org:victor Sep 1, 2023
1 check passed
@colliand
Copy link

The logo image for Project VICTOR is not appearing on the login page. FYI @volcanocyber.

@damianavila
Copy link

I think the problem is described in this comment by @consideRatio: 2i2c-org/infrastructure#3067 (comment).

@volcanocyber
Copy link
Author

volcanocyber commented Sep 13, 2023

I don't fully follow. @damianavila Does the logo need to be local? Not too familiar with the Python templates.

@consideRatio
Copy link
Member

@volcanocyber in #26 there was a change made to a file called jupyterhub_config.py, that jupyterhub config is never used when you visit https://victor.2i2c.cloud/ though. Instead, that config would only be used if you wanted to try how your login page would look locally.

What is needed is that the configuration in 2i2c-org/infrastructure is updated, specifically the config here.

Do you want us to update that config based on information from this PR, so that its reflected at https://victor.2i2c.cloud/?

        'org': {
            'name': 'VICTOR',
            'logo_url': 'https://i.imgur.com/D2vXQ5k.png',
            'url': 'https://victor.ldeo.columbia.edu',
        },
        'operated_by': {
            'name': '2i2c',
            'url': 'https://2i2c.org',
            'custom_html': '',
        },
        'funded_by': {
            'name': 'National Science Foundation',
            'url': 'https://people.climate.columbia.edu/projects/sponsor/National%20Science%20Foundation',
            'custom_html': 'Funding <i>Org</i>',
        },
        'designed_by': {
            'name': '2i2c',
            'url': 'https://2i2c.org',
            'custom_html': '',
        }

@consideRatio
Copy link
Member

@volcanocyber I went ahead and updated the configuration that influences staging.victor.2i2c.cloud and victor.2i2c.cloud in 2i2c-org/infrastructure#3133 feeling confident this was desired and about to end my work day.

@consideRatio
Copy link
Member

image

@damianavila damianavila requested review from consideRatio and removed request for consideRatio September 25, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

5 participants