Update version of notebook package #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in jupyter/notebook#6221 to potentially fix 2i2c-org/infrastructure#1170
|
|
choldgraf
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
This looks good to me!
Though I am confused why we aren't installing the "latest" version of the Jupyter Notebook with this environment.yml file anyway. Here is my thinking:
- If no dependency pins the
notebookpackage, I assume thatcondawould install the latest released version. In which case specifying this shouldn't make a difference. - If a dependency does pin the
notebookpackage, then us setting a minimum should create a version conflict, right?
|
@choldgraf repo2docker was pinning notebook to 6.3.0 for python 3.6 compatibility reasons. Just opened jupyterhub/repo2docker#1149 to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in jupyter/notebook#6221 to potentially fix
2i2c-org/infrastructure#1170