Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for stream mode. #366

Merged
merged 5 commits into from
Jun 22, 2024
Merged

add tests for stream mode. #366

merged 5 commits into from
Jun 22, 2024

Conversation

Ox0400
Copy link
Contributor

@Ox0400 Ox0400 commented Jun 19, 2024 •
edited
Loading

usage:

python examples/cmd/run.py "hello,my name is tom"
python examples/cmd/run.py hello,my name is tom
python examples/cmd/run.py --stream hello, my name is tom

@Ox0400
add tests for stream mode.
c428007 
usage: python examples/cmd/run.py --stream "hello,my name is tom"
@Ox0400 Ox0400 mentioned this pull request Jun 19, 2024
Merged
fumiama
fumiama requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to represent the merit of stream mode?

examples/cmd/run.py Outdated Show resolved Hide resolved
examples/cmd/run.py Outdated Show resolved Hide resolved
@fumiama fumiama added enhancement New feature or request ui UI improvements & issues labels Jun 19, 2024
fumiama
fumiama requested changes Jun 20, 2024
View reviewed changes
examples/cmd/run.py Outdated Show resolved Hide resolved
fumiama
fumiama requested changes Jun 20, 2024
View reviewed changes
examples/cmd/run.py Outdated Show resolved Hide resolved
@Ox0400 Ox0400 force-pushed the add-tests-stream-mode branch from d66bc79 to e062458 Compare June 20, 2024 08:42
@Ox0400
Copy link
Contributor Author

Ox0400 commented Jun 20, 2024

@fumiama updated, plz review

fumiama
fumiama requested changes Jun 20, 2024
View reviewed changes
examples/cmd/run.py Outdated Show resolved Hide resolved
@fumiama fumiama merged commit a41ce63 into 2noise:main Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fumiama fumiama fumiama approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ui UI improvements & issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ox0400 @fumiama