Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/98 handle page titles #107

Merged
merged 9 commits into from
Feb 27, 2020
Merged

Task/98 handle page titles #107

merged 9 commits into from
Feb 27, 2020

Conversation

bellangerq
Copy link
Member

  • Import react-helmet to handle page titles.
  • Add title to every page.
  • Set page title logic in Header component.

ThunderDev1
ThunderDev1 reviewed Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@ThunderDev1 ThunderDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, had never used helmet before. Don't forget the podium page ;)

client/src/components/Header/Header.tsx Outdated Show resolved Hide resolved
client/src/components/Header/Header.tsx Outdated Show resolved Hide resolved
client/src/components/Header/Header.tsx Show resolved Hide resolved
client/src/components/Header/Header.tsx Outdated Show resolved Hide resolved
client/src/pages/About/About.tsx Show resolved Hide resolved
client/src/pages/Game.tsx Outdated Show resolved Hide resolved
@bellangerq bellangerq force-pushed the task/98-handle-page-titles branch from 7f82e0f to 6ee2e6f Compare February 27, 2020 12:57
@ThunderDev1 ThunderDev1 self-requested a review February 27, 2020 13:09
@bellangerq bellangerq merged commit 6508994 into master Feb 27, 2020
@bellangerq bellangerq deleted the task/98-handle-page-titles branch February 27, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThunderDev1 ThunderDev1 ThunderDev1 approved these changes

@hissalht hissalht Awaiting requested review from hissalht

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bellangerq @ThunderDev1