Join a game #38
Merged
Join a game #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThunderDev1
commented
Dec 3, 2019
ThunderDev1
commented
- Player presence in game is based on socket connection: on connect, add to database, on disconnect remove.
- Allow multiple independant game lobbies
- Lobby host is the oldest lobby member
- Use cooler random names
- QnD styling for player display in lobby
- Added some missing types
- Update readme
The host is now the oldest member of the lobby
ThunderDev1
force-pushed
the
task/3-join-a-game
branch
from
66ac4f5 to
c05083e
Compare
hissalht
approved these changes
Dec 5, 2019
| navigate(`/lobby/${game.id}`) | ||
| }) | ||
| const createGame = async () => { | ||
| const postGameResponse: AxiosResponse<Game> = await axios.post(`/games`) |
There was a problem hiding this comment.
nice, can we also provide an error type ?
There was a problem hiding this comment.
No specific errors to catch here, maybe inside a global error handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.