Skip to content

Commit

Permalink
Criteo Bid Adapter: Fix invalid deal property name mapping from bidde…
Browse files Browse the repository at this point in the history
…r response (prebid#9808)

Currently, our PBJS adapter code expects to receive a property called 'dealCode' where our bidder emits 'deal' instead.
We've updated our backend to temporary emit both dealCode & deal but long term we'd like to align to use 'deal 'across all integrations.
  • Loading branch information
leonardlabat authored Apr 14, 2023
1 parent 67c778a commit e7c26f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion modules/criteoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export const spec = {
creativeId: slot.creativecode,
width: slot.width,
height: slot.height,
dealId: slot.dealCode,
dealId: slot.deal,
};
if (body.ext?.paf?.transmission && slot.ext?.paf?.content_id) {
const pafResponseMeta = {
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/criteoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1475,7 +1475,7 @@ describe('The Criteo bidding adapter', function () {
creativecode: 'test-crId',
width: 728,
height: 90,
dealCode: 'myDealCode',
deal: 'myDealCode',
adomain: ['criteo.com'],
}],
},
Expand Down

0 comments on commit e7c26f8

Please sign in to comment.