XCH-1994: Construct Video ORTB #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Across/Prebid.js into XCH_1994_construct_video_ortb
terryc33x
reviewed
Oct 15, 2020
terryc33x
reviewed
Oct 15, 2020
terryc33x
reviewed
Oct 15, 2020
terryc33x
reviewed
Oct 15, 2020
terryc33x
reviewed
Oct 15, 2020
terryc33x
reviewed
Oct 15, 2020
curlyblueeagle
commented
Oct 16, 2020
curlyblueeagle
commented
Oct 16, 2020
|
|
||
| const builtServerRequests = spec.buildRequests(bidRequests, {}); | ||
|
|
||
| expect(JSON.parse(builtServerRequests[0].data)).to.deep.equal(ttxRequest); |
There was a problem hiding this comment.
Changing assert to compare the built request rather than server payload serverRequest since the latter has ttxRequest stringified and therefore order matters making the tests very brittle.
terryc33x
reviewed
Oct 19, 2020
terryc33x
reviewed
Oct 19, 2020
terryc33x
reviewed
Oct 20, 2020
modules/33acrossBidAdapter.md
Outdated
| video: { | ||
| playerSize: [300, 250], | ||
| context: 'outstream', | ||
| placement: '2' |
terryc33x
reviewed
Oct 20, 2020
| playerSize: [300, 250], | ||
| context: 'outstream', | ||
| placement: '2' | ||
| ... // Aditional ORTB video params |
There was a problem hiding this comment.
since mimes and protocols are required, better to put it in the doc
terryc33x
reviewed
Oct 20, 2020
| ad: { | ||
| video: { | ||
| content: bid.vastXml, | ||
| player_height: bid.playerHeight, |
There was a problem hiding this comment.
not sure the bid.playerHeight|Width is standard, that may exist in APNX adapter only, please double check. if it does not exists, then just suggest with w & h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds the video ORTB and also refines video param validation