VCPKG as primary dependency manager (and internal submodules as optional) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaiaeroastro
requested review from
alexanderoster,
martinweismann,
3dJan,
gangatp and
ewaldbrADSK
|
May be the problem is related to this issue microsoft/vcpkg#25349 , vcpkg is cloned properly, but the dependencies of vcpkg.json are not. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #397 +/- ##
========================================
Coverage 66.08% 66.08%
========================================
Files 395 395
Lines 44625 44625
========================================
Hits 29492 29492
Misses 15133 15133 ☔ View full report in Codecov by Sentry. |
|
We probably should fix this in the cpp bindings and act first. |
3dJan
approved these changes
Dec 10, 2024
| @@ -11,7 +11,8 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| submodules: true | |||
| submodules: recursive | |||
| fetch-depth: 0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates VCPKG as a submodule in the repository.
It introduces an CMake option -DUSE_PACKAGED_SUBMODULES and this is turned off by default.
It handles everything including libressl. I have tested with both options and the tests also seem to run through.