Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update data feed test #121

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

JulissaDantes
Copy link
Contributor

This PR introduces 3 main changes:

  • Un-skips the resumability test, and uses the resume Token
  • Updates the Event accumulator to be able to include a resume token
  • Updates the codec test to include the resumeToken field

Please wait until its not longer a draft to review, just in case some side-efforts will result in updates to this PR.

@JulissaDantes JulissaDantes marked this pull request as ready for review May 7, 2024 12:35
Copy link
Collaborator

@stbrody stbrody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Some nitpick feedback, more for future reference than anything, but would be nice to have a more descriptive PR name and commit message, something that includes how/why the test is being updated. So something like "feat: Test data feed resumability"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants