Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restore test coverage of updates #132

Merged
merged 3 commits into from
May 29, 2024
Merged

feat: Restore test coverage of updates #132

merged 3 commits into from
May 29, 2024

Conversation

stbrody
Copy link
Collaborator

@stbrody stbrody commented May 23, 2024

The fact that the update test has been skipped for so long, means that the anchor and longevity tests have also effectively been skipped as well since they'll never find any documents in the database to test against.

This PR makes several changes:

  • Adds updates to the explicit model-correctness.test.ts
  • Re-enables update.test.ts after switching it to use MIDs instead of TileDocuments
  • Updates anchor.test.ts and longevity.test.ts to work with streams in the database that are either TileDocuments OR ModelInstanceDocuments.

Copy link
Collaborator

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the cleanup and the switch to MIDs!! Looks so much nicer 🚀

@stbrody stbrody added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 53248f6 May 29, 2024
8 checks passed
@stbrody stbrody deleted the testUpdates branch May 29, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants