Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create test for all event types #135

Conversation

stephhuynh18
Copy link
Contributor

We need a test capable of creating each event type in order to test we can migrate all data.

Copy link

linear bot commented Jun 6, 2024

Copy link
Collaborator

@stbrody stbrody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -1,6 +1,6 @@
import { type ModelDefinition } from '@ceramicnetwork/stream-model'

export const newModel: ModelDefinition = {
export const MODEL_DEFINITION_LIST: ModelDefinition = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, can we call this LIST_MODEL_DEFINITION or MODEL_LIST_DEFINITION (and apply the same convention to the other constants here).

When I first saw this I thought it was a list of model definitions, not a definition of a model with the list account relation.

@stephhuynh18 stephhuynh18 added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit da3dc69 Jun 10, 2024
8 checks passed
@stephhuynh18 stephhuynh18 deleted the feature/aes-95-create-test-that-creates-events-of-_all_-kinds branch June 10, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants