feat: test bi-directional syncing in update test #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
force-pushed
the
enable-cas-tests-aes-6
branch
from
2dae25a
to
c0e5ba1
Compare
stbrody
force-pushed
the
bidirection-sync-test-aes-6
branch
from
8d3907c
to
0d4acd4
Compare
stbrody
commented
Jun 13, 2024
| const expectedContent = { step: ComposeDbUrls.length } | ||
| // `step` is incremented once for the first r/w node and twice for each subsequent node, | ||
| // during the `update` test, so use the length of the r/w URL array to test the content. | ||
| const expectedContent = { step: 1 + (ComposeDbUrls.length - 1) * 2 } |
There was a problem hiding this comment.
note this is going to break the longevity tests for existing streams in the database that were created with the old version of the update test that had fewer steps. We might need to coordinate merging this PR with clearing out the dynamodb database to prevent spurious failures, unfortunately
|
Nevermind! This test already tests syncing in both directions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #143.
Testing that syncing works in both directions in the update test lets us remove the (much slower and more expensive) ceramic-ceramic-integration.test.ts as then there's nothing it's testing that isn't covered by other tests