feat: expose storage class for IPFS containers #148
Conversation
| @@ -110,6 +117,7 @@ impl Default for RustIpfsConfig { | |||
| memory: Some(Quantity("512Mi".to_owned())), | |||
| storage: Quantity("1Gi".to_owned()), | |||
| }, | |||
| storage_class: None, | |||
There was a problem hiding this comment.
I'm not sure exactly how this will evaluate with Rust.
If there is no storageClassName specified, then the PVC should not set one, not even an empty string, so that the default storageClassName is applied.
https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class-1
There was a problem hiding this comment.
That is what is happening, if no storage class is specified in the spec then its not set on the PVC spec itself. Rust does this via the Option<String> type, where None means its not set and Some("some_storage_class_name") is set. This also means that None is different than Some("") i.e. the empty string. We do not use Some("") in these code paths. We either set it to None or to Some with a non empty string.
No description provided.