feat: support configuring persistent storage for containers #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
force-pushed
the
feat/configurable-disk
branch
from
5fe0754
to
590ab39
Compare
dav1do
force-pushed
the
feat/configurable-disk
branch
from
590ab39
to
b6da2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add persistent storage config object that allows modifying the persistent volume storage size and class. I updated a handful of tests to set this, so we see the 10 -> override value, demonstrating that the default is still 10 (and shown in tests that haven't been updated). If preferable, I can write dedicated tests for this new setting.
For IPFS, we allowed specifying
storageClassbefore. We still support this field, but will prefer thestorage.classfield if it is set. If not, we will usestorageClass(there are existing tests that demonstrate this).