fix: use composedb develop image by default #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrz2001
force-pushed
the
fix/cdb-develop-image
branch
from
1db3821
to
a3be84b
Compare
samika98
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
LGTM!
nit -> The load.py in the local-scripts dir still has some old images. It would be nice if we can set the images there to the defaults as well.
Line 3 in b2429b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns all the default versions of the software we set up in Keramik:
ceramic-one:latest/js-ceramic:develop/composedb:develop/ceramic-anchor-service:develop.Our tests will usually specify explicit versions of the software being tested.
Thanks for bringing this up, @samika98.