Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compatibility): Conflict with other modules #11

Merged
merged 1 commit into from
Mar 11, 2015

Conversation

minorOffense
Copy link
Contributor

Other modules declaring packages conflict with this module. Instead, switch to ensure_packages()from puppetlabs-stdlib.

You'll need to add the dependency to puppetlabs-stdlib in the module info.

Other modules declaring packages conflict with
this module. Instead, switch to ensure_packages()
from puppetlabs-stdlib
@igoraj
Copy link
Member

igoraj commented Mar 10, 2015

Sorry for late response. You mean when other modules don't use ensure_packages or if defined() syntax they are conflicting with this one?
Well, I can certainly see how this can be an issue, but I'm a bit worried because ensure_packages appeared only in stdlib 4.x which drops support for Puppet 2.7 (which is default in Ubuntu 12.04LTS, still widely used).

@minorOffense
Copy link
Contributor Author

Exactly. The declarations from other puppet modules using defined() create catalog errors.

What about a conditional block that checks the version of stdlib installed? If ensure_packages is there use it, fallback otherwise.

@igoraj
Copy link
Member

igoraj commented Mar 11, 2015

Actually what I said yesterday is not true. It seems they had the same problem, and decided in the end not to break backwards compatibility in 4.x. (read more here). When stdlib 5.x comes out it will drop support for older versions of puppet. So I can merge your PR and add dependency on stdlib 4.x with no issues (at least I hope there will not be any :))

@igoraj igoraj merged commit 5160c81 into 3fs:master Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants