C API bindings for libthreescalers.{so,a} #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it also set profile.release to perform full LTO.
…ode` generic This lifts the need to check the strings coming in from the C boundary and enables better ergonomics for this function.
We are exposing it in two ways to check on the ergonomics, but should eventually settle on one.
…_ints
c_int::from(bool) relies on the semantics documented in the Rust
reference so that:
i{32,64,etc}::from(b: bool) will return 0 with b == false and 1 with b
== true.
This change also uses `return {0,1,-1}` without an explicit From::from
for c_int as suggested by clippy. The semantics now require that a
(signed) C integer has a direct representation as a signed Rust one _as
inferred by the compiler_ (ie. i32, i64, ...).
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 66.82% 60.35% -6.47%
==========================================
Files 31 36 +5
Lines 2146 2376 +230
==========================================
Hits 1434 1434
- Misses 712 942 +230
Continue to review full report at Codecov.
|
unleashed
force-pushed
the
capi
branch
4 times, most recently
from
98e219e
to
b3afde5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up cargo-c to generate a dynamic/static library and a C header file.
Includes infrastructure to expose Rust functions and modules, and so far includes: