THREESCALE-11281 - bump to go 1.22 #1036

valerymo · 2024-11-27T10:25:25Z

Jira: https://issues.redhat.com/browse/THREESCALE-11281

Verification

Install and sanity validation
3scale installed locally

~/go/3scale-operator git branch --show-current
THREESCALE-11281-1


cd 3scale-operator
make install
export NAMESPACE=3scale-test
oc new-project $NAMESPACE
oc project $NAMESPACE
make download
make run

Installed correctly
routes/UI verified

~/go/3scale-operator oc project
Using project "3scale-test" on server "https://api.vmo01.xxxxx".
~/go/3scale-operator date                     
Wed Nov 27 19:17:24 EET 2024
~/go/3scale-operator git branch --show-current
THREESCALE-11281-1
~/go/3scale-operator oc get deploy            
NAME                 READY   UP-TO-DATE   AVAILABLE   AGE
apicast-production   1/1     1            1           36m
apicast-staging      1/1     1            1           36m
backend-cron         1/1     1            1           40m
backend-listener     1/1     1            1           40m
backend-redis        1/1     1            1           40m
backend-worker       1/1     1            1           40m
system-app           1/1     1            1           34m
system-memcache      1/1     1            1           40m
system-mysql         1/1     1            1           40m
system-redis         1/1     1            1           40m
system-searchd       1/1     1            1           40m
system-sidekiq       1/1     1            1           36m
zync                 1/1     1            1           36m
zync-database        1/1     1            1           36m
zync-que             1/1     1            1           36m
~/go/3scale-operator

CVEs analysys
Quay.io Security Scan - Passed

Image was built to see CVE check in Quay.io.
Repo: quay.io/vmogilev_rhmi/3scale-operator:test-go122
Command used to build image (on Mac arm):

docker build . --platform linux/amd64 -t quay.io/vmogilev_rhmi/3scale-operator:test-go122

MStokluska · 2024-11-28T08:09:48Z

PROJECT

- group: apps
+-
+  # TODO(user): Uncomment the below line if this resource implements a controller, else delete it.
+  # controller: true


This should be uncommented right?

done. Thank you

MStokluska · 2024-11-28T08:10:12Z

PROJECT

- group: apps
+-
+  # TODO(user): Uncomment the below line if this resource implements a controller, else delete it.
+  # controller: true


This too? Can you review this file again please

done. Thank you

MStokluska · 2024-11-28T08:11:04Z

PROJECT

  kind: APIManager
+  # TODO(user): Update the package path for your API if the below value is incorrect.
+  path: k8s.io/api/apps/v1alpha1


this is wrong

fixed. Thank you

MStokluska · 2024-12-11T11:11:22Z

Makefile

@@ -281,6 +286,9 @@ bundle-validate: $(OPERATOR_SDK)

 .PHONY: bundle-update-test
 bundle-update-test:
+	# Remove the createdAt field before checking the diff
+    sed -i '/createdAt:/d' ./bundle/manifests/3scale-operator.clusterserviceversion.yaml


this looks hacky Valery, we shouldn't do that because essentially the bundle will be created in our build system and that flag will be there. Is there no other way around it? (I'll try finding a different approach as well)

you can remove the createdAt from the config/manifest/bases/3scale-opreator.clusterserviceversion.yaml
The flag is updated if present, if not, it's not.

MStokluska · 2024-12-11T11:51:37Z

bundle/manifests/3scale-operator.clusterserviceversion.yaml

@@ -1161,4 +1166,25 @@ spec:
  maturity: stable
  provider:
    name: Red Hat
+  relatedImages:


would be nice to:

figure out where this is coming from / why?

redis and psql have no "name" values - why

check midstream for possible clash when updating these values for prod release.

MStokluska · 2024-12-11T11:52:28Z

bundle/manifests/3scale-operator.clusterserviceversion.yaml

@@ -240,12 +240,13 @@ metadata:
    categories: Integration & Delivery
    certified: "false"
    containerImage: quay.io/3scale/3scale-operator:master
-    createdAt: "2019-05-30T22:40:00Z"
+    createdAt: "2024-11-27T13:51:25Z"


as above, if we remove it from base we won't have it, I don't think this is a mandatory field for csv validation. Please remove

MStokluska · 2024-12-11T11:53:17Z

bundle/manifests/apps.3scale.net_apimanagerrestores.yaml

@@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
  annotations:
-    controller-gen.kubebuilder.io/version: v0.9.2
+    controller-gen.kubebuilder.io/version: v0.14.0


@carlkyrillos was there something about this bump that you had an issue with in one of your previous PRs?

controller-gen v0.9.2 has a problem with GO 1.22 - following steps failed: assets-validate, bundle-validate, run-unit-tests, test-crds. All with same/similar error in controller-gen - segmentation fault , as for example

/home/circleci/project/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..." panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa00d6f]

Looks like known Issue - kubernetes-sigs/controller-tools#880 . People using newer controller-gen 0.14 . Same version used also in marin3r.

MStokluska · 2024-12-11T12:00:27Z

@valerymo left some comments, in general, could you explain to me why are we pinning operator-sdk bump to go bump?
If operator SDK bump is really required, we should follow (or at least review) the migration steps in go operators here:
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/ - that said, I think stuff like "controllers should now be in internal/controllers" could potentially be skipped, but it would be good to review the migration required from 1.2 to 1.28 just to be extra cautious...

valerymo · 2024-12-16T13:47:50Z

@valerymo left some comments, in general, could you explain to me why are we pinning operator-sdk bump to go bump? If operator SDK bump is really required, we should follow (or at least review) the migration steps in go operators here: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/ - that said, I think stuff like "controllers should now be in internal/controllers" could potentially be skipped, but it would be good to review the migration required from 1.2 to 1.28 just to be extra cautious...

@MStokluska , I had problems using go 1.22 with operator-sdk 1.2. So the question was - which verion of operator-sdk to migrage. Here’s a summary of the versions and their compatibility with Go 1.22.

Go Version	Operator SDK Version	Notes
Go 1.18 - 1.20	Operator SDK 1.2	Works well with Go 1.18 and 1.19, but may cause issues with Go 1.22 due to Go modules changes.
Go 1.21 - 1.22	Operator SDK 1.28+	Fully compatible with Go 1.21 and 1.22. Recommended version for Go 1.22.

After using operator-sdk 1.28 - all builds and tests worked fine.
One more reason for operator-sdk 1.28 -- marin3r using it.
I'm rechecking now GO1.22 without change of Operator SDK 1.2.0 - this is PR THREESCALE-11281 - bump to go 1.22 #1045 . Will update after testing. Thank you Michal !

valerymo · 2024-12-17T14:07:41Z

This PR will be closed, it's replaced by new one #1045 - that does not change OperatorSDK.

We have verified that 3scale-operator with the existing version of OperatorSDK 1.2 works with GO 1.22.
- the reason of fails in several tests (segmentation faults) was Not old OperatorSDK 1.2, but controller-gen (see next item)
controller-gen update was done same way as here, from v0.9.2 to v0.14.0 due to incompatibility of controller-gen v0.9.2 with GO 1.22 (segmentation fault).
The SDK upgrade will be addressed in a future task. cc @MStokluska @carlkyrillos

valerymo requested a review from a team as a code owner November 27, 2024 10:25

openshift-ci bot added the do-not-merge/work-in-progress label Nov 27, 2024

valerymo force-pushed the THREESCALE-11281-1 branch 9 times, most recently from 0260d86 to 3326fa3 Compare November 27, 2024 15:03

valerymo changed the title ~~[WIP]THREESCALE-11281 - bump to go 1.22~~ THREESCALE-11281 - bump to go 1.22 Nov 27, 2024

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 27, 2024

MStokluska reviewed Nov 28, 2024

View reviewed changes

THREESCALE-11281 - bump to go 1.22

72415b2

valerymo force-pushed the THREESCALE-11281-1 branch from 3326fa3 to 72415b2 Compare December 4, 2024 14:57

MStokluska reviewed Dec 11, 2024

View reviewed changes

valerymo mentioned this pull request Dec 17, 2024

THREESCALE-11281 - bump to go 1.22 #1045

Open

valerymo closed this Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

THREESCALE-11281 - bump to go 1.22 #1036

THREESCALE-11281 - bump to go 1.22 #1036

valerymo commented Nov 27, 2024 •

edited

Loading

MStokluska Nov 28, 2024

valerymo Dec 4, 2024

MStokluska Nov 28, 2024

valerymo Dec 4, 2024

MStokluska Nov 28, 2024

valerymo Dec 4, 2024

MStokluska Dec 11, 2024

MStokluska Dec 11, 2024

MStokluska Dec 11, 2024

MStokluska Dec 11, 2024

MStokluska Dec 11, 2024

valerymo Dec 17, 2024 •

edited

Loading

MStokluska commented Dec 11, 2024 •

edited

Loading

valerymo commented Dec 16, 2024 •

edited

Loading

valerymo commented Dec 17, 2024 •

edited

Loading

THREESCALE-11281 - bump to go 1.22 #1036

THREESCALE-11281 - bump to go 1.22 #1036

Conversation

valerymo commented Nov 27, 2024 • edited Loading

Verification

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valerymo Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

MStokluska commented Dec 11, 2024 • edited Loading

valerymo commented Dec 16, 2024 • edited Loading

valerymo commented Dec 17, 2024 • edited Loading

valerymo commented Nov 27, 2024 •

edited

Loading

valerymo Dec 17, 2024 •

edited

Loading

MStokluska commented Dec 11, 2024 •

edited

Loading

valerymo commented Dec 16, 2024 •

edited

Loading

valerymo commented Dec 17, 2024 •

edited

Loading