Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump penlight from 1.7.0 to 1.31.1 #1447

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented Feb 9, 2024

What

This commit also removes filesystem.lua as the issue has been fixed in penlight v1.8.0

lunarmodules/Penlight#329

The dev image is already run with version 1.13.1
https://github.com/3scale/APIcast/blob/master/gateway/Roverfile.lock#L29

Verification Steps

  • Build docker image from this git branch
make runtime-image IMAGE_NAME=apicast-test
  • HTTP dev environment setup
cd dev-environments/plain-http-upstream
make gateway IMAGE_NAME=apicast-test

The gateway should be running without error

  • The request should be accepted (200 OK)
curl --resolve get.example.com:8080:127.0.0.1 -v "http://get.example.com:8080/?user_key=123"

@tkan145 tkan145 marked this pull request as ready for review February 9, 2024 03:41
@tkan145 tkan145 requested a review from a team as a code owner February 9, 2024 03:41
This commit also removes filesystem.lua as the issue with dir.dirtree
has been fixed in penlight v1.8.0

lunarmodules/Penlight#329
@tkan145 tkan145 changed the title Bumped penlight from 1.7.0 to 1.31.1 Bump penlight from 1.7.0 to 1.31.1 Feb 9, 2024
Copy link
Member

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification steps working

@tkan145
Copy link
Contributor Author

tkan145 commented Feb 14, 2024

Added CHANGELOG entry. Because there is a new commit in PR, I need a new approval.

@eguzki eguzki merged commit df57f8b into 3scale:master Feb 14, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants