Bump nokogiri from 1.10.10 to 1.13.6 #2988
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/bundler/nokogiri-1.13.6
branch
from
5ccf0f7
to
e3dcf7a
Compare
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.10 to 1.13.6. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.10...v1.13.6) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/bundler/nokogiri-1.13.6
branch
from
e3dcf7a
to
4a48e9e
Compare
| @@ -22,7 +22,7 @@ def to_node(options) | |||
| doc = options.fetch(:doc) | |||
| xml = to_xml(builder: builder) | |||
|
|
|||
| Nokogiri::XML::Node.new('root', doc).replace(xml) | |||
| Nokogiri::XML::Node.new('root', doc).add_child(xml) | |||
There was a problem hiding this comment.
This looks good to me, however I am a little worry this may change the behavior and I don't see any tests related to JSONRepresenter. If I am not mistaken this class manages the JSON format response for models such as
porta/app/representers/application_plans_representer.rb
Lines 1 to 7 in 25fa9bc
Maybe it is covered by integration tests... I am not sure. Have you tested this manually by calling some 3scale API endpoints?
There was a problem hiding this comment.
Can you also explain this change? Did API change or what is the point?
There was a problem hiding this comment.
@josemigallas I have done some manual tests with 3scale API endpoints and they are working.
@akostadinov the way Nokogiri::XML::Node#new works has changed and now when introducing the xml we need to have a parent node (created at #new). What #add_child does is introducing the xml code inside that parent. I have checked with the console when bundle exec rails t test/integration/user-management-api/buyers_users_test.rb:476.
You can check the differences here: https://diffonline.net/yPYv9bxyVP
There was a problem hiding this comment.
JSONRepresenter is used by many other representers:
$ rg JSONRepresenter
test/test_helpers/represented_api_routing.rb
27: include ThreeScale::JSONRepresenter
35: include ThreeScale::JSONRepresenter
44: include ThreeScale::JSONRepresenter
52: include ThreeScale::JSONRepresenter
app/representers/access_token_representer.rb
4: include ThreeScale::JSONRepresenter
app/representers/account_plan_representer.rb
2: include ThreeScale::JSONRepresenter
...
to_node is probably used for XML representing.
@lvillen , what I didn't understand is why replace stopped working. #add_child I assume would be equivalent to #replace when same element does not exist anymore. But is it possible same element to exist? Is it possible to make #replace work?
Perhaps it is fine to have it like it is though. Still it is preferable to understand :)
This reverts commit 401ad8c.
Bump nokogiri from 1.10.10 to 1.13.6
Bumps nokogiri from 1.10.10 to 1.13.6.
Release notes
Sourced from nokogiri's releases.
... (truncated)
Changelog
Sourced from nokogiri's changelog.
... (truncated)
Commits
b7817b6version bump to v1.13.661b1a39Merge pull request #2530 from sparklemotion/flavorjones-check-parse-memory-ty...83cc451fix: {HTML4,XML}::SAX::{Parser,ParserContext} check arg types22c9e5bversion bump to v1.13.56155881doc: update CHANGELOG for v1.13.5c519a47Merge pull request #2527 from sparklemotion/2525-update-libxml-2_9_14-v1_13_x66c2886dep: update libxml2 to v2.9.14b7c4cc3test: unpend the LIBXML_LOADED_VERSION test on freebsdeac7934dev: require yamlf3521bastyle(rubocop): pend Style/FetchEnvVar for nowDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.