Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Update manual installation #3229

Merged
merged 2 commits into from
Mar 2, 2023
Merged

📝 Update manual installation #3229

merged 2 commits into from
Mar 2, 2023

Conversation

josemigallas
Copy link
Contributor

  • macOS requires mysql and postgresql as dependencies.
  • macOS requires a flag in order to run mysql in docker
  • rewording

@josemigallas josemigallas requested a review from a team March 2, 2023 08:48
@josemigallas josemigallas self-assigned this Mar 2, 2023
akostadinov
akostadinov reviewed Mar 2, 2023
View reviewed changes
fedora-manual-setup.md Outdated Show resolved Hide resolved
akostadinov
akostadinov reviewed Mar 2, 2023
View reviewed changes
osx-manual-setup.md Outdated Show resolved Hide resolved
akostadinov
akostadinov reviewed Mar 2, 2023
View reviewed changes
osx-manual-setup.md
brew link imagemagick@6
```

* **Macs with M1** also require de following:
* **Macs with M1** also require the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you include heare the instructions to install local-fastimage_resize?
#3065 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the PR is verified and merged, yes

akostadinov
akostadinov reviewed Mar 2, 2023
View reviewed changes
osx-manual-setup.md Outdated Show resolved Hide resolved
akostadinov
akostadinov previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@akostadinov akostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments. Since what you did is a clear improvement, if you don't want to deal with more changes, feel free to merge.

@josemigallas josemigallas force-pushed the manual_install_doc_update branch from b372cf8 to 47cb876 Compare March 2, 2023 13:27
@josemigallas josemigallas merged commit 208656a into master Mar 2, 2023
@josemigallas josemigallas deleted the manual_install_doc_update branch March 2, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akostadinov akostadinov akostadinov left review comments

Assignees

@josemigallas josemigallas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemigallas @akostadinov