Hotfix: pagination skip 오류 수정 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IntersectionType 을 쓰는경우, dto의 apiproperty가 아닌경우, 속성을 가져오지 않아서 - skip을 가져오지 않는 오류가 발생 - utils에서 따로 처리하도록 로직 변경
mimseong
approved these changes
Mar 14, 2022
|
skip 속성이 어떤 속성이에요?? 궁금 |
|
예를들어 한 페이지에 글이 10개고, 3번째 page 내용을 가져오는거라면 앞에 20개의 글은 skip해야하는데, 이때 20을 계산 하던 getter 프로퍼티였여요 |
|
아아 원하는 페이지 외의 글을 제외하기 위해 쓰이는 거군요! 이해했습니다. |
Skyrich2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
바뀐점
페이지네이션에서 skip 속성을 가져오지 못해서 utils에서 따로 처리하도록 변경
바꾼이유
IntersectionType 을 사용할떄, skip 속성을 가져오지 않아서, skip이 undefined 가 된다.
설명
utils에 getPaginationSkip 함수를 하나 만들어서 사용하도록 변경했습니다.