Fix: exclude img from search #300

Yaminyam · 2022-08-12T09:49:32Z

바뀐점

검색할때 img 태그에 포함된 내용을 제외

바꾼이유

#299
img 태그에 포함된 검색어를 검색시 이미지가 포함된 모든 게시글이 검색됨

설명

🔥 Main Merge 1주차 🏃‍♀️🏃‍♂️🏃

🔥 Main Merge 2주차 🏃‍♀️🏃‍♂️🏃

🔥 Main Merge 3주차 🏃‍♀️🏃‍♂️🏃

2월 마지막주 main

0.0.2 배포

🔥 Main Merge 🏃‍♀️🏃‍♂️🏃

Setting: 자동으로 assignee 할당해주는 액션 추가

5월 배포

This reverts commit dc65ec7.

Revert "Setting: 자동으로 assignee 할당해주는 액션 추가"

🔥 Main Merge 🏃‍♀️🏃‍♂️🏃

Skyrich2000 · 2022-08-13T13:28:38Z

apps/api/src/article/article.service.ts

+        article.content.replace(/![\S*](\S+)/g, '').indexOf(options.q) !== -1 ||
+        article.title.indexOf(options.q) !== -1,
+    );
+    return { articles: filteredArticles, totalCount };


생각해보니까 totalCount 개수가 안맞으면 pagenation 이 잘 안될 수 있겠네유......
이거는 db query를 손봐야할거같은데 query에서 정규식을 써야할수도 있겠네유....

아..그러게요 토탈카운트도 같이 변경해야할까요

articles는 페이지네이션된 배열이 나온거고, totalCount 는 전체 검색결과 개수라서...
db 단에서 처리해야할거같아요

Db에서 정규식을 먹일수 있으려나 좀 알아봐야겠네요

regex_like 같은게 있는거같더라구용

https://codingspooning.tistory.com/entry/MySQL-%EC%A0%95%EA%B7%9C%ED%91%9C%ED%98%84%EC%8B%9D-%EA%B2%80%EC%83%89%ED%95%98%EA%B8%B0-REGEXP-LIKE

chichoon · 2022-09-07T05:30:18Z

apps/api/src/article/repositories/article.repository.ts

-            q: `%${options.q}%`,
-          });
+          qb.where('article.title like :q', { q: `%${options.q}%` }).orWhere(
+            'regexp_replace(`article`.`content`, "!\\[[[:print:]]+\\]\\([[:print:]]+\\)", "") like :q',


정규식고수시네요

아 이거 게시글 검색할때 이미지 날려주는 그 정규식인가요
[:print:] 는 무엇인가요

저희가 javascript에서 사용하는 정규식은 좋은 정규식인데 mysql은 구려서 posix라는 정규식을 사용해서
[:print:]+가 s+ 라고 생각하시면 됩니다...ㅋㅋ

https://m.blog.naver.com/PostView.naver?isHttpsRedirect=true&blogId=nawoo&logNo=220033645634

헐 특이하네요 ㅋㅋㅋ

chichoon · 2022-09-07T05:30:50Z

infra/docker-compose.yml

@@ -61,9 +61,8 @@ services:
        order: start-first
  #-----------------------------------------------------------------------------------
  db:
-    image: mysql:5.7
+    image: mysql:8.0


mysql의 버전을 올리셨군요 멋집니다

mysql 5버전에서는 정규식 지원이 안되고
8버전이 쿼리처리 속도도 훨씬 빠르다고해서 저번에 같이 날잡고 업글했습니다! ㅎㅎ

그리고보니 요거는 저번에 버전 올리던 PR이 따로 있지 않았나요?

@Skyrich2000 체리픽 입니다 ㅋㅋ

Skyrich2000 · 2022-09-07T17:44:58Z

apps/api/test/e2e/article.e2e-spec.ts

+    const contentWithoutSearchWord =
+      'bbbbbb![image.png](https://42world-image.s3.ap-northeast-2.amazonaws.com/111111111.png)';


기존 테스트를 수정하기보다는, 이미지 링크에 있는 숫자는 제외하는 테스트를 따로 추가하는편이 좋을거같아요

테스트한다고 수정했었던것 같은데 잊고있었네요 ㅋㅋ

Skyrich2000 · 2022-09-07T17:47:28Z

이런식응로 db 와 직접적으로 소통하는 repository는 unit test 를 어떻게 짜야할지 고민되긴 하네요 @rockpell 님 이런건 어떻게 mocking 하나요?

rockpell · 2022-09-07T23:52:29Z

이런식응로 db 와 직접적으로 소통하는 repository는 unit test 를 어떻게 짜야할지 고민되긴 하네요 @rockpell 님 이런건 어떻게 mocking 하나요?

레포지토리 유닛 테스트는 데이터베이스 붙여서 테스트하면 될거 같습니다

blingblin-g

정규식 고수네요 👍

Skyrich2000 and others added 16 commits January 16, 2022 22:59

Merge pull request #20 from 42-world/develop

dbc11ce

🔥 Main Merge 1주차 🏃‍♀️🏃‍♂️🏃

Merge pull request #26 from 42-world/develop

b4eb48f

🔥 Main Merge 2주차 🏃‍♀️🏃‍♂️🏃

Merge pull request #54 from 42-world/develop

49511e4

🔥 Main Merge 3주차 🏃‍♀️🏃‍♂️🏃

Merge branch 'develop' into main

a8f24bb

Merge branch 'develop' into main

3a83e23

Merge pull request #129 from 42-world/develop

36d2910

2월 마지막주 main

Merge pull request #153 from 42-world/develop

e4917be

0.0.2 배포

Merge pull request #231 from 42-world/develop

7b8ced8

🔥 Main Merge 🏃‍♀️🏃‍♂️🏃

Setting: 자동으로 assignee 할당해주는 액션 추가

dc65ec7

Merge pull request #243 from 42-world/feature/assign-action

70789db

Setting: 자동으로 assignee 할당해주는 액션 추가

Merge pull request #248 from 42-world/develop

ac0ae53

5월 배포

Revert "Setting: 자동으로 assignee 할당해주는 액션 추가"

90a094f

This reverts commit dc65ec7.

Merge pull request #256 from 42-world/feature/revert-action

8f6f44c

Revert "Setting: 자동으로 assignee 할당해주는 액션 추가"

Merge pull request #291 from 42-world/develop

5e1b0f1

🔥 Main Merge 🏃‍♀️🏃‍♂️🏃

Merge pull request #297 from 42-world/develop

b57a550

🔥 Main Merge 🏃‍♀️🏃‍♂️🏃

Fix: exclude img from search

bc7409d

Yaminyam changed the title ~~Fix/exclude img from search~~ Fix: exclude img from search Aug 12, 2022

github-actions bot assigned Yaminyam Aug 12, 2022

Yaminyam added 3 commits August 12, 2022 18:56

Fix: markdown img

5f2077b

Fix: content without search word article test

002e017

Fix: markdown image

b3a8e66

Skyrich2000 reviewed Aug 13, 2022

View reviewed changes

Skyrich2000 added skip:ci github action 작동을 skip and removed skip:ci github action 작동을 skip labels Aug 27, 2022

Skyrich2000 and others added 3 commits September 7, 2022 01:06

feat: mysql 버전업

82817e9

fix: test 에도 적용

14085e1

Fix: exclude img tag for search

5f8df6e

Yaminyam added the bug Something isn't working label Sep 6, 2022

Yaminyam linked an issue Sep 6, 2022 that may be closed by this pull request

[Bug] 검색에서 이미지 링크 제외 #299

Closed

chichoon reviewed Sep 7, 2022

View reviewed changes

Fix: search totalCount

40aed3d

Yaminyam requested a review from Skyrich2000 September 7, 2022 05:58

Skyrich2000 reviewed Sep 7, 2022

View reviewed changes

Yaminyam added 2 commits September 8, 2022 22:44

Test: image 태그를 제외한 검색

c2a1615

Fix: import lint

8b688b8

Yaminyam requested a review from Skyrich2000 September 8, 2022 15:04

rockpell approved these changes Sep 16, 2022

View reviewed changes

blingblin-g approved these changes Sep 16, 2022

View reviewed changes

Yaminyam merged commit d4d0c6d into develop Sep 16, 2022

Yaminyam deleted the fix/exclude-img-from-search branch September 16, 2022 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: exclude img from search #300

Fix: exclude img from search #300

Yaminyam commented Aug 12, 2022

Skyrich2000 Aug 13, 2022

Yaminyam Aug 13, 2022

Skyrich2000 Aug 13, 2022

Yaminyam Aug 13, 2022

Skyrich2000 Aug 14, 2022

chichoon Sep 7, 2022

chichoon Sep 7, 2022

Yaminyam Sep 7, 2022

Yaminyam Sep 7, 2022

Skyrich2000 Sep 7, 2022

chichoon Sep 7, 2022

Yaminyam Sep 7, 2022

Skyrich2000 Sep 7, 2022

Yaminyam Sep 7, 2022

Skyrich2000 Sep 7, 2022

Yaminyam Sep 7, 2022

Skyrich2000 commented Sep 7, 2022

rockpell commented Sep 7, 2022

blingblin-g left a comment

		const contentWithoutSearchWord =
		'bbbbbb![image.png](https://42world-image.s3.ap-northeast-2.amazonaws.com/111111111.png)';

Fix: exclude img from search #300

Fix: exclude img from search #300

Conversation

Yaminyam commented Aug 12, 2022

바뀐점

바꾼이유

설명

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Skyrich2000 commented Sep 7, 2022

rockpell commented Sep 7, 2022

blingblin-g left a comment

Choose a reason for hiding this comment