Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added flag, whether or not a multi tenant app and added tests to test… #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fingineering
Copy link

Changes

Added a feature flag, to enable authentication, when using a multitenant application

Added the parameter multitenant to the list of global variables, which defaults to false. Therefore the existing behavior is preserved.
In case of a multitenant=True the issuer of the token is omited during the decoding.

Tests

Added two tests:

  1. testing with an oauth token, whether the requires_auth works.
  2. resting if an token from a different tenant works

enabled the setting of CLIENT_ID, TENANT_ID and USER_TOKEN via environment variables in a way that the original behavior is preserved

@fingineering
Copy link
Author

@cmatskas missed to set you as a reviewer, maybe you like to review this PR and merge, if acceptable? It is related to issue #16

@cmatskas
Copy link
Contributor

cmatskas commented Jun 1, 2023

I’m sorry but I don’t have access to this repo anymore :(

@fingineering
Copy link
Author

What a pity, anyone else, who can help, or is this repo abandoned?

@cmatskas
Copy link
Contributor

cmatskas commented Jun 1, 2023

I hope so. Either the Azure AD SDKs team or the new owners of this repo. You may want to shoot a tweet to the @AzureAD Twitter account with this issue. Put some public pressure. Tagging @JefTek as well

@emirkmo
Copy link

emirkmo commented Jan 20, 2024

@fingineering or @cmatskas since it is MIT licensed, any chance one of you are willing to be the maintainer and we fork it? Or do you recommend something else to use instead?

@cmatskas
Copy link
Contributor

@emirkmo unfortunately, as much as I would like to help, I’m not part of Microsoft and I don’t have a permission to manage this repo any more. At this point, IMHO your best bet would be to fork the repo

@emirkmo
Copy link

emirkmo commented Jan 27, 2024

Thanks, will do that. Didn't want to step on any toes.

@fingineering
Copy link
Author

Pardon the late response, well, in principle I could try to maintain the repo and the package - but I'm not part of Microsoft as well.

@lsmith77
Copy link
Contributor

FTR I have forked the code into my codebase. Since I didn’t need all the features I stripped it down a bit. I could see myself open sourcing it but would much rather latch onto someone with my experience maintaining an open source python package.

I do warn to alert anyone using this package that python-jose is unmaintained as well and the first security issues have popped up mpdavis/python-jose#341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants