FEAT: github student

42Benefit · May 29, 2023 · 90bbf9c · 90bbf9c · vercel · May 29, 2023
1 parent 78d6637
commit 90bbf9c
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -23,7 +23,8 @@
 		"dotenv": "^16.0.3",
 		"googleapis": "^114.0.0",
 		"three": "^0.150.1",
-		"typeit": "^8.7.1"
+		"typeit": "^8.7.1",
+		"validator": "^13.9.0"
 	},
 	"licenses": [
 		{

diff --git a/src/component/Benefit/Benefit.svelte b/src/component/Benefit/Benefit.svelte
@@ -3,6 +3,7 @@
 	import { onMount, afterUpdate } from "svelte";
 	import dateFormat from "dateformat";
 	import ftLogo from "$lib/images/42logo.svg";
+	import { isURL } from 'validator';
 	import ColorThief from "colorthief";
 
 	/**
@@ -113,7 +114,11 @@
 		</button>
 		<ol class="method-list">
 			{#each benefit.method as element}
-				<li>{element}</li>
+				{#if isURL(element)}
+					<a href={element}><li>{element}</li></a>
+				{:else}
+					<li>{element}</li>
+				{/if}
 			{:else}
 				<li>구체적인 신청방법 준비되지 않음. 해당회사에 문의.</li>
 			{/each}
@@ -122,6 +127,10 @@
 </section>
 
 <style>
+
+	a {
+		color: inherit;
+	}
 	.benefit {
 		display: flex;
 		flex-direction: column;

diff --git a/src/data/student.json b/src/data/student.json
@@ -19,8 +19,7 @@
         "category": "교육",
         "content": "학생인 동안 무료로 GitHub Pro를 사용하세요.",
         "method": [
-            "GitHub 웹사이트에서 바로 접근",
-            "GitHub 지원에서 도움 받기"
+            "https://github-portal.42.fr/login"
         ],
         "startDate": "",
         "endDate": ""