Discord embed looks dodgy

[qaisjp]

Describe the bug

Sending a series of links on Discord causes output on Slack that seems to miss a leading newline.

To Reproduce
Steps to reproduce the behavior:

1. Send https://youtube.com/ https://google.com/ https://discordapp.com/ on Discord
2. Look at Slack
3. If it doesn't work, send https://youtube.com/ https://google.com/ https://discordapp.com/ on Discord again
4. Look at slack

You might have to do it a second time because I think Discord unfurling is late.

Note that the first time those link appear in Slack, you will see Slack's unfurling — Slack's unfurling won't appear the second time because they only unfurl once per "recent conversation" (to prevent embeds spamming up your screen). To get around Slack's unfurl "spam protection", you can cache bust by appending something to the query string: https://youtube.com/?1

Expected behavior

Either have a newline, or don't send Discord embeds if they are only unfurl embeds.

Screenshots/debug logs

Environment (please complete the following information):

e9edbfc, macOS

Additional context

Nothing of significance other than ShowEmbeds:

[discord]
[discord.mta]
Token="..."
Server="..."
RemoteNickFormat="{NICK}"
WebhookURL="..."
ShowEmbeds=true

[slack]
[slack.mta]
Token="..."
RemoteNickFormat="{NICK}"

[42wim]

Hm tried to reproduce this, but nothing happens on the slack side, tried sending multiple times.

[42wim]

@qaisjp still an issue ?

[qaisjp]

Um let me try and reproduce on latest master (can't now though)

To confirm you've tried cache busting, right?

[42wim]

No I haven't, but I couldn't produce it on the first message.

[qaisjp]

I can definitely reproduce this on 2d8f749

it only works after the first message (because discord has the embed cached)