Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a space between caption text and the colon from telegram messages on the irc side #1089

Closed
derram opened this issue Apr 14, 2020 · 4 comments
Closed

Add a space between caption text and the colon from telegram messages on the irc side #1089

derram opened this issue Apr 14, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@derram
Copy link

derram commented Apr 14, 2020

If a URL is used as a caption on telegram, the colon breaks the URL on irc side.

Selection_400
@derram derram added the enhancement New feature or request label Apr 14, 2020
@42wim
Copy link
Owner

42wim commented Apr 18, 2020

Please paste debug logs reproducing this issue.
I don't use telegram and need the debug logs.

@42wim 42wim added the waiting for feedback Further information is requested label Apr 18, 2020
@derram
Copy link
Author

derram commented Apr 19, 2020

teletoircdebug.txt

Pretty sure I included the relevant bits, hopefully I didn't exclude or censor something important.

42wim added a commit that referenced this issue Apr 19, 2020
@42wim
Add extra space before colon in attachments (irc). Fixes #1089
27f0e83
@42wim 42wim closed this as completed in f7ec9af Apr 19, 2020
@42wim
Copy link
Owner

42wim commented Apr 19, 2020

Thanks, fixed in master now.

@42wim 42wim removed the waiting for feedback Further information is requested label Apr 19, 2020
@42wim 42wim mentioned this issue Apr 19, 2020
Merged
@derram
Copy link
Author

derram commented Apr 19, 2020

Thanks again!

jwflory added a commit to FOSSRIT/infrastructure that referenced this issue Apr 20, 2020
@jwflory
🆙 matterbridge: v1.17.1 -> v1.17.3
096375f 
Periodic version bump. A few upstream changes highlighted that may be
relevant for us:

    https://github.com/42wim/matterbridge/releases/tag/v1.17.3

v1.17.3
=======

* irc: Add JoinDelay option (irc). Fixes 42wim/matterbridge#1084
  (42wim/matterbridge#1098)
* slack: Clip too long messages on 3000 length (slack). Fixes
    * This one will definitely affect RIT FOSS for IRC/Matrix/Riot users
      with really long messages to Slack.
  42wim/matterbridge#1081 (42wim/matterbridge#1102)
* slack: Prevent image/message looping (slack). Fixes
  42wim/matterbridge#1088 (42wim/matterbridge#1096)
* irc: Add extra space before colon in attachments (irc). Fixes
  42wim/matterbridge#1089 (42wim/matterbridge#1101)

v1.17.2
=======

* slack: Update vendor slack-go/slack (42wim/matterbridge#1068)

Signed-off-by: Justin W. Flory <git@jwf.io>
@jwflory jwflory mentioned this issue Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@42wim @derram