-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when receiving webhook via MS Teams channel #1141
Comments
Thought it might be helpful to see the JSON that Syncro is sending: {
"@type": "MessageCard",
"@context": "https://schema.org/extensions",
"summary": "A Ticket was created \n\n Customer: Customer,\nNumber: 6618,\nSubject: Test, \nType: Software, \nInitial Issue: Test",
"themeColor": "0078D7",
"title": "Ticket",
"sections": [
{
"text": "A Ticket was created \n\n Customer: Customer,\nNumber: 6618,\nSubject: Test, \nType: Software, \nInitial Issue: Test"
}
],
"potentialAction": [
{
"@type": "OpenUri",
"name": "View",
"targets": [
{
"os": "default",
"uri": "https://xxxx.syncromsp.com/tickets/xxxx"
}
]
}
]
} |
Ignore these messages for now, also add a extra debug option for msteams so we can dump the whole message.
Thanks for the clear report, I fixed the crash in master for now by ignoring messages that are not from users. I've also added a extra debug option for msteams, you can enable it by This will dump the complete message and give more information. Could you please open a new issue requesting notification sync for msteams and paste the debug messages you got from the new debug option. You can find a test binary here: https://bintray.com/beta/#/42wim/nightly/Matterbridge/v1.17.4-14-g1630b4c?tab=files or just build from master. |
Describe the bug
We have our PSA (Syncro https://syncromsp.com/) send notifications to MS Teams via webhook. When these notifications are received, matterbridge crashes. We have not tried other webhooks, but regular messages seem to work fine.
To Reproduce
Obviously not something everyone can do as the webhook post is coming from a paid service
Expected behavior
We are expecting the notification to be synchronized to Mattermost
Screenshots/debug logs
Debug logs
Environment (please complete the following information):
version: 1.17.4 6c442e2
Additional context
bridge.toml:
The text was updated successfully, but these errors were encountered: