Update vendor yaegashi/msgraph.go to v0.1.2 #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you rebase / tested the changes in my fork? |
|
matterbridge binary builds, but I haven't tested ms teams. The only content commit in your fork is matterbridge/msgraph.go@ce5df2f and I can confirm that the enums are corrected in the v0.1.2 ➜ ag "type BodyType"
vendor/github.com/yaegashi/msgraph.go/beta/EnumBody.go
6:type BodyType string
➜ ag "type ChatMessageImportance"
vendor/github.com/yaegashi/msgraph.go/beta/EnumChat.go
6:type ChatMessageImportance string
➜ ag "type ChatMessageType"
vendor/github.com/yaegashi/msgraph.go/beta/EnumChat.go
124:type ChatMessageType stringSo I've switched it over from your fork to the upstream repo. |
|
(The enum types were fixed in yaegashi/msgraph.go@a886f8c upstream) |
|
Ok, I'll test this if I can find some time. |
|
Okay! |
|
Thanks! tested and working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They fixed the macOS bug I was having - yaegashi/msgraph.go#11