Fix #1039: messages sent to Slack being synced back #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression from 42wim#581 (comment) Behaves the same as matterbridge/slack@95190f1
qaisjp
force-pushed
the
hotfix/slack-message-duplication
branch
from
71cfc5a to
ab697c8
Compare
|
Wow, good catch! Thanks for the detective work 👍 |
jwflory
added a commit
to FOSSRIT/infrastructure
that referenced
this pull request
Mar 27, 2020
Matterbridge upstream released a new minor feature release:
https://github.com/42wim/matterbridge/releases/tag/v1.17.0
There are a good number of changes, including support for Microsoft
Teams. (What?!) But the relevant bits of the changelog for us are below:
* general: support JSON and YAML config formats
(42wim/matterbridge#1045)
* irc: Be less lossy when throttling IRC messages
(42wim/matterbridge#1004)
* slack: Use upstream slack-go/slack again (42wim/matterbridge#1018)
* slack: Ignore ConnectingEvent (42wim/matterbridge#1041)
* slack: use blocks not attachments (42wim/matterbridge#1048)
* slack: Fix 42wim/matterbridge#1039: messages sent to Slack being
synced back (42wim/matterbridge#1046)
And a hat tip to our upstream devs who made this release possible:
@qaisjp, @jakubgs, @burner1024, @notpushkin, @MartijnBraam, and @42wim.
This upgrade is currently running in production without issue. This
commit brings the config management up to date with what is currently
running out in prod.
Signed-off-by: Justin W. Flory <git@jwf.io>
kennedy
pushed a commit
to FOSSRIT/infrastructure
that referenced
this pull request
Mar 29, 2020
Matterbridge upstream released a new minor feature release:
https://github.com/42wim/matterbridge/releases/tag/v1.17.0
There are a good number of changes, including support for Microsoft
Teams. (What?!) But the relevant bits of the changelog for us are below:
* general: support JSON and YAML config formats
(42wim/matterbridge#1045)
* irc: Be less lossy when throttling IRC messages
(42wim/matterbridge#1004)
* slack: Use upstream slack-go/slack again (42wim/matterbridge#1018)
* slack: Ignore ConnectingEvent (42wim/matterbridge#1041)
* slack: use blocks not attachments (42wim/matterbridge#1048)
* slack: Fix 42wim/matterbridge#1039: messages sent to Slack being
synced back (42wim/matterbridge#1046)
And a hat tip to our upstream devs who made this release possible:
@qaisjp, @jakubgs, @burner1024, @notpushkin, @MartijnBraam, and @42wim.
This upgrade is currently running in production without issue. This
commit brings the config management up to date with what is currently
running out in prod.
Signed-off-by: Justin W. Flory <git@jwf.io>
This was referenced Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression from #581 (comment)
Behaves the same as matterbridge/slack@95190f1
Easiest fix without changing upstream is to set the fallback string to a zero width space.
Fixes #1039