Remove build dependencies from final image (multistage build) #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42wim
requested changes
Mar 22, 2020
Dockerfile
Outdated
| @@ -9,3 +8,8 @@ RUN apk update && apk add go git gcc musl-dev ca-certificates mailcap \ | |||
| && go build -x -ldflags "-X main.githash=$(git log --pretty=format:'%h' -n 1)" -o /bin/matterbridge \ | |||
| && rm -rf /go \ | |||
| && apk del --purge git go gcc musl-dev | |||
|
|
|||
| FROM alpine:edge | |||
| RUN apk --no-cache add ca-certificates | |||
There was a problem hiding this comment.
Suggested change
| RUN apk --no-cache add ca-certificates | |
| RUN apk --no-cache add ca-certificates mailcap |
We need mailcap for mimetypes: see #969
There was a problem hiding this comment.
I was unsure if that was a build dependency or not. I'll update the branch.
|
Thank you, good idea! |
This multistage build takes the resulting image size down from 346MB to 90MB.
awigen
commented
Mar 22, 2020
Dockerfile
Outdated
| @@ -9,3 +8,8 @@ RUN apk update && apk add go git gcc musl-dev ca-certificates mailcap \ | |||
| && go build -x -ldflags "-X main.githash=$(git log --pretty=format:'%h' -n 1)" -o /bin/matterbridge \ | |||
| && rm -rf /go \ | |||
| && apk del --purge git go gcc musl-dev | |||
|
|
|||
| FROM alpine:edge | |||
| RUN apk --no-cache add ca-certificates | |||
There was a problem hiding this comment.
I was unsure if that was a build dependency or not. I'll update the branch.
42wim
approved these changes
Mar 22, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This multistage build takes the resulting image size down from 346MB to
90MB.