set rmsg.Event in RocketChat bridge #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for the PR! |
ldruschk
force-pushed
the
rocketchat-set-events
branch
from
645af03 to
7290177
Compare
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this requires the following pull request in the matterbridge/Rocket.Chat.Go.SDK project to be merged (and CI is probably going to fail until then): matterbridge/Rocket.Chat.Go.SDK#2
This pull request properly sets the events
EventJoinLeaveandEventTopicChangefor messages from the RocketChat bridge and drops messages which are neither one of those events nor plain messages. (Is this behavior desirable? Otherwise all messages like changing the role of a user in a channel are relayed without a corresponding Event and are thus spammed in the connected bridges)I haven't found guidelines for contributers so if I should change anything or "sign" a CLA or whatever let me know.