Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement User Avatar spoofing of XMPP users #1090

Merged

Conversation

PapaTutuWawa
Copy link
Contributor

This PR adds the functionality to spoof the avatar of XMPP users in different bridges. This solves #1024.

NOTE: Since the CI was signaling mistakes, I fixed
them and squashed the individual "fixing commits"
into this one.
@PapaTutuWawa PapaTutuWawa force-pushed the upstream/finally-i-figured-rebase-out branch from 1d88a88 to ba4b2ec Compare April 15, 2020 20:21
bridge/xmpp/helpers.go Outdated Show resolved Hide resolved
@42wim 42wim added this to the 1.17.3 milestone Apr 16, 2020
@42wim
Copy link
Owner

42wim commented Apr 16, 2020

Thanks, looks good! 👍
Tested it on xmpp server without avatar support and no issues.
Not sure if we'll get an issue because of the PubsubRequestLastItems on every message though.

@42wim 42wim merged commit 7183095 into 42wim:master Apr 16, 2020
@42wim 42wim mentioned this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants