Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slack real name as user name #1775

Merged
merged 4 commits into from
Mar 26, 2022
Merged

Conversation

sas1024
Copy link
Contributor

@sas1024 sas1024 commented Mar 22, 2022

Added new option to use Slack real name as user name.

@42wim
Copy link
Owner

42wim commented Mar 25, 2022

I think we better keep the same naming convention and also use UseFullName here like with telegram.
In the comments you can refer to the slack real name name

@sas1024
Copy link
Contributor Author

sas1024 commented Mar 25, 2022

@42wim done! :)

@42wim 42wim added the slack label Mar 25, 2022
@42wim 42wim added this to the 1.25.0 milestone Mar 25, 2022
@codeclimate
Copy link

codeclimate bot commented Mar 25, 2022

Code Climate has analyzed commit b2b0e12 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim merged commit 6fe0cff into 42wim:master Mar 26, 2022
@42wim
Copy link
Owner

42wim commented Mar 26, 2022

👍

@sas1024 sas1024 deleted the use-real-name-slack branch March 27, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants