Ignore sending file with comment, if comment contains IgnoreMessages value #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 9a090f5 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
IgnoreMessagessetting check and attached file comment too.How I test it:
In Slack bridge configuration I set
IgnoreMessages="^~~"Old Behavior:
Sending message with attached file from Slack to Telegram with file comment "~~ test comment" sends this file to Telegram.
New Behavior:
Sending message with attached file from Slack to Telegram with file comment "~~ test comment" not sends this file to Telegram.