make getChannelIdTeam behave like GetChannelId for groups #873
Conversation
|
I believe this would be better factored out into some helper function, but I'm not really sure where to put it. I came across the discrepancy while testing 42wim/matterircd#255. |
|
OK, so it looks like I've a choice: fail lint ("should use |
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
|
OK, that looks like it passes CI for you. I even made you a nice refactor. |
|
Github believes there are changes requested, but I changed the lines in question and resolved the rquest. Am I missing something, or is Github? |
|
Sorry for the delay! |
#873) GetChannelId will support names generated from query groups when a team is not set, but not when a team is set since it falls through to getChannelIdTeam which has a different inner loop. i This pull makes the two implementations do the same thing.
42wim#873) GetChannelId will support names generated from query groups when a team is not set, but not when a team is set since it falls through to getChannelIdTeam which has a different inner loop. i This pull makes the two implementations do the same thing.
GetChannelIdwill support names generated from query groups when a team is not set, but not when a team is set since it falls through togetChannelIdTeamwhich has a different inner loop. This pull makes the two implementations do the same thing.