Adding QuoteLengthLimit option for Feature request: #963 #985
Conversation
…QuoteLengthLimit = 0 the whole message will be quoted
|
Travis complains about one simple readability improvement. |
bridge/xmpp/xmpp.go
Outdated
| @@ -11,7 +11,7 @@ import ( | |||
| "github.com/42wim/matterbridge/bridge/config" | |||
| "github.com/42wim/matterbridge/bridge/helper" | |||
| "github.com/jpillora/backoff" | |||
| "github.com/matterbridge/go-xmpp" | |||
| "github.com/humorhenker/go-xmpp" | |||
There was a problem hiding this comment.
It should keep go-xmpp from matterbridge
bridge/xmpp/xmpp.go
Outdated
| @@ -331,7 +331,7 @@ func (b *Bxmpp) skipMessage(message xmpp.Chat) bool { | |||
| } | |||
|
|
|||
| // skip empty messages | |||
| if message.Text == "" { | |||
| if message.Text == "" && message.Chatstate == "" { | |||
There was a problem hiding this comment.
If you want to change this, please open a new PR for this change (it's not related to the QuoteLengthLimit feature)
|
Thanks for the PR! I've added some comments to your code.
No, you can just push commits (that will fix the issues travis complains about) to your branch (master in your case) Travis will rebuild this PR with every commit you push. |
|
Updated now. |
|
Thanks! No worries, your git-fu will grow :) |
FR #963 asked for an option to limit the max quoted message length.
QuoteLengthLimit option added to limit max. quoted message length.
If QuoteLengthLimit = 0 the whole message will be quoted.