Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matterircd 0.7 sends privmsg that cannot be parsed #53

Closed
jtdaugherty opened this issue Jun 22, 2016 · 9 comments
Closed

matterircd 0.7 sends privmsg that cannot be parsed #53

jtdaugherty opened this issue Jun 22, 2016 · 9 comments

Comments

@jtdaugherty
Copy link

Hi,

I'm using matterircd 0.7 and it sent a message to my chat client that the client could not parse:

irc: too few arguments received from IRC server for command "privmsg" (received: 3 arguments, expected: at least 4)
irc: failed to parse command "PRIVMSG" (please report to developers):
:dwest!ysthswine3f8bgqqse38c1pg7c@https://mattermost.galois.com PRIVMSG #questions-and-feedback

I've spoken with the chat client authors (weechat) and they're claiming that this is not an RFC-compliant message. (That issue is at weechat/weechat#751.)

CC @dwest-galois

@42wim
Copy link
Owner

42wim commented Jun 22, 2016

I can't reproduce this in 0.8. How did this happen ? How does this look from mattermost side (which version) ? Can you try matterircd 0.8 (and run with -debug) and try to reproduce it?

Seems like it received a empty message from mattermost

@jtdaugherty
Copy link
Author

I think @dwest-galois messaged me from MatterMost while I was logged into Weechat. We've ugpraded to 0.8 since this happened, so I'll keep an eye out for it happening again. If we were to run with debugging enabled, what would that enable that we should pass on to you (e.g. log files, etc.)?

@42wim
Copy link
Owner

42wim commented Jun 22, 2016

-debug dumps a lot of info on stderr, the same PRIVMSG would also be visible in the debug output. I'd need a few lines before, this would show what was send from mattermost.

But I think I just found the issue, your friend probably pasted an image in a channel/private message without a text.

@jtdaugherty
Copy link
Author

Ah! Fantastic! I'll keep an eye out either way, but thank you for looking into this.

@jtdaugherty
Copy link
Author

(And I was wrong: we will upgrade to 0.8 tomorrow.)

42wim added a commit to 42wim/mm-go-irckit that referenced this issue Jun 22, 2016
42wim added a commit that referenced this issue Jun 22, 2016
@42wim
Copy link
Owner

42wim commented Jun 22, 2016

It's fixed in master now, but I suppose it didn't crash the weechat client ? just a log/warning message ?

@jtdaugherty
Copy link
Author

Yeah, I only got the text I posted in the original report; the client did not crash.

@dwest-galois
Copy link

Is this going to be released in v0.8.1 or v0.9? I'm just looking for an ETA so that I can plan updates accordingly.

@42wim
Copy link
Owner

42wim commented Jun 22, 2016

Sorry, no ETA yet. I'll do a v0.8.1 if there's a crashing/critical bug, but this is not the case for this one.
It depends on how many other bugs pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants