Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve on logging and make consistent with matterclient #510

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Improve on logging and make consistent with matterclient #510

merged 1 commit into from
Mar 29, 2023

Conversation

hloeung
Copy link
Collaborator

@hloeung hloeung commented Nov 20, 2022 •
edited
Loading

I like to think it's an improvement.

Rather than append "module=matterircd" and such, have the module prefixed much like what's used by matterclient. Also split out what's logged by the main matterircd or the bridges (mattermost & slack).

[2022-11-19T22:19:20Z] DEBUG matterclient: found 162 channels for user in team ...
[2022-11-19T22:19:20Z] DEBUG matterclient: found 1333 public channels in team ...
[2022-11-19T22:19:20Z] DEBUG matterclient: WsClient: making connection: wss://myserver.mydomain.local
[2022-11-19T22:19:21Z] DEBUG matterclient: WsClient: connected
[2022-11-19T22:19:21Z] DEBUG matterclient: starting wsreceiver
[2022-11-19T22:19:21Z] DEBUG matterclient: executing OnWsConnect()
[2022-11-19T22:19:21Z] DEBUG matterircd: bridge not ready yet, sleeping
[2022-11-19T22:19:21Z]  INFO bridge/mattermost: login succeeded
...
[2022-11-19T22:32:16Z] DEBUG matterircd: in handleChannelMessageEvent
[2022-11-19T22:32:16Z] DEBUG bridge/mattermost: handleFileEvent() user hloeung sent 1 files
model.StringArray{"6qo5jidzg7y3uexwfuhkdg9wkw"}
[2022-11-19T22:32:16Z] DEBUG bridge/mattermost: handleWsActionPost() user hloeung sent

@hloeung hloeung force-pushed the logging-with-module-and-prefix branch 2 times, most recently from 57c4943 to 470002a Compare November 20, 2022 00:30
@hloeung hloeung marked this pull request as ready for review November 20, 2022 01:01
@hloeung hloeung force-pushed the logging-with-module-and-prefix branch 3 times, most recently from 7d53a6e to be0468e Compare November 20, 2022 04:38
@hloeung hloeung requested a review from 42wim November 22, 2022 22:08
@hloeung hloeung force-pushed the logging-with-module-and-prefix branch 2 times, most recently from be0468e to 61ee94b Compare December 4, 2022 23:20
@hloeung hloeung force-pushed the logging-with-module-and-prefix branch from dd25d9f to 96ae4be Compare March 16, 2023 02:17
@42wim 42wim added this to the 0.27.1 milestone Mar 29, 2023
@42wim 42wim merged commit cd2cfe0 into 42wim:master Mar 29, 2023
@42wim
Copy link
Owner

42wim commented Mar 29, 2023

Thanks and sorry for the delay

@hloeung hloeung deleted the logging-with-module-and-prefix branch March 30, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42wim 42wim Awaiting requested review from 42wim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hloeung @42wim