Add basic support for syntax highlighting in code blocks #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
syntax-highlighting
branch
from
f6922b3
to
956a219
Compare
|
Added workaround to alecthomas/chroma#716 for now. |
hloeung
force-pushed
the
syntax-highlighting
branch
2 times, most recently
from
b2cd02d
to
d1782d1
Compare
hloeung
changed the title
hloeung
force-pushed
the
syntax-highlighting
branch
from
d1782d1
to
ee4cebb
Compare
42wim
reviewed
Dec 3, 2022
There was a problem hiding this comment.
That looks pretty cool :)
Some small remarks:
- not necessary for this PR, but for the next PR I think it's maybe better to move the codeblock handling to a separate method.
- what are your thoughts about instead of making 3 extra options using just one like eg SyntaxHighlighting="formatter:style" if it's empty it's not used and otherwise get the formatter/style out of it ?
Sounds good, updated PR implementing this - 3 extra options down to just one. Thanks for your review. |
42wim
reviewed
Dec 3, 2022
hloeung
force-pushed
the
syntax-highlighting
branch
from
c362da3
to
e0d5ccd
Compare
|
Okay, ready to go / review. Thanks and much appreciated. |
hloeung
force-pushed
the
syntax-highlighting
branch
2 times, most recently
from
7571b49
to
328251d
Compare
hloeung
force-pushed
the
syntax-highlighting
branch
from
328251d
to
7625bd2
Compare
42wim
reviewed
Dec 14, 2022
hloeung
force-pushed
the
syntax-highlighting
branch
from
b066e4f
to
7625bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is right now, it will only use syntax highlighting on code blocks where it specifies syntax highlighting, that is ```blah. This is because it's a very basic implementation where we're doing per-line.
Ideally, we'll want to buffer up code block lines and then pass it through to https://github.com/alecthomas/chroma which will then analyse and try to determine what style to use if none provided.