Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/21 option to load firestore key from dict #77

Merged
merged 16 commits into from
Apr 15, 2024

Conversation

444B
Copy link
Owner

@444B 444B commented Apr 15, 2024

Pull Request Template

TL;DR

Provide a brief summary of the changes made.

  • users can now use st.secrets to access their firebase credentials. Details for how to do this will be added to the wiki entry soon.
  • function use is as such:
with streamlit_analytics.track(verbose=True, streamlit_secrets_firestore_key="firebase_key", firestore_project_name=st.secrets["project_name"], firestore_collection_name=st.secrets["collection_secret"]):

Problem Solved

  1. Describe the problem your changes address.
  2. Please mention the issue number if relevant

Screenshots

If applicable, add screenshots to help explain your solution. For adding images, use:

  • N/A

Changes Made(Optional)

List the main changes in bullet points.

  1. Evaluate the current behaviour of SA2 with firebase
  2. Evaluate problem scope discussed in Issue and solution suggested by upstream PR
  3. Once problem and solution are validated, Integrate selected code changes of PR (since upstream is OOD)
  4. verify behavior and no breaking changes

Manual Testing

  • You have manually tested all changes to ensure they work as intended. Replace the [ ] with a [X] if True.

How was this tested?
Describe the tests that you ran to verify your changes.

  • Via run_checks.sh
  • via packages on test.pypi.com which are them installed on a fresh codespace and verified by seeing data enter firebase when using st.secrets for credential handling

Additional Notes

Include any additional information that might be relevant for reviewers.

  • Although the function uses a string and st.secrets for argument handling, this will change once a config screen is developed that will remove the need to configure the app via function arguments and will be done via a UI.

@444B 444B self-assigned this Apr 15, 2024
@444B 444B linked an issue Apr 15, 2024 that may be closed by this pull request
@444B 444B merged commit 8c5ecf3 into main Apr 15, 2024
4 checks passed
@444B 444B deleted the test/21-option-to-load-firestore-key-from-dict branch April 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to load firestore key from dict
1 participant