Missing unit test #137
Merged
Missing unit test #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 17, 2017 19:46
set default pagination
delete default pagination
minor fixes
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=====================================
Coverage 88% 88%
=====================================
Files 36 36
Lines 550 550
Branches 2 2
=====================================
Hits 484 484
Misses 66 66Continue to review full report at Codecov.
|
AdrianRaFo
force-pushed
the
arf-131-Missing-unit-test
branch
from
6c6b1fb
to
47212ee
Compare
juanpedromoreno
force-pushed
the
arf-131-Missing-unit-test
branch
from
64583a1
to
47212ee
Compare
BenFradet
reviewed
May 18, 2017
| |}""".stripMargin | ||
|
|
||
| val httpClientMock = httpClientMockPostOAuth[OAuthToken]( | ||
| url = "http://127.0.0.1:9999/login/oauth/access_token", |
There was a problem hiding this comment.
I'm curious as to why you had to specify the whole url?
| |}""".stripMargin | ||
|
|
||
| val httpClientMock = httpClientMockPost[Gist]( | ||
| url = s"gists", |
There was a problem hiding this comment.
string interpolation isn't necessary
| validNote, | ||
| Some("master")) | ||
| } | ||
|
|
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131