Fixes ghost users associated with pull requests, issues and comments #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFradet
reviewed
May 22, 2017
There was a problem hiding this comment.
I'm wondering if the following couldn't be affected too:
- https://github.com/47deg/github4s/blob/jp-fix-null-users/github4s/shared/src/main/scala/github4s/free/domain/Repository.scala#L23 : I guess not otherwise there wouldn't be any repo
- https://github.com/47deg/github4s/blob/jp-fix-null-users/github4s/shared/src/main/scala/github4s/free/domain/Repository.scala#L73 : I guess not since we're only supporting creating release atm but in the future we might want to support the GET endpoints
- https://github.com/47deg/github4s/blob/jp-fix-null-users/github4s/shared/src/main/scala/github4s/free/domain/Repository.scala#L137 : I don't think so either since if there is no owner for the repository there are no statuses (I guess)
What do you think?
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=====================================
Coverage 88% 88%
=====================================
Files 36 36
Lines 550 550
Branches 2 1 -1
=====================================
Hits 484 484
Misses 66 66
Continue to review full report at Codecov.
|
|
👍
|
|
Anyway, let's make optional releases and statuses. |
Merged
BenFradet
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one user is removed completely from Github, the API returns null (https://github.com/ghost), a possibility not contemplated until now.
This PR makes the users associated with issues, pull requests and issue comments as an optional field.