-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sbt-org-policies to 0.7.4 #164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 40 40
Lines 606 606
Branches 3 3
=======================================
Hits 531 531
Misses 75 75 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This setting would be only for badge purposes. If we want to bump to the latest version of Scalajs, we need to bump up also the sbt-org-policies version: https://github.com/47deg/sbt-org-policies/releases/tag/v0.6.3
Thanks, I wasn't entirely sure sbt-org-policies needed to be involved, I'll take care of 47degrees/sbt-org-policies#538 as well then. |
@BenFradet I needed to upgrade sbt-org-policies and btw I upgraded everything in general: 47degrees/sbt-org-policies#632, including Scalajs. |
Thanks a lot! I'll bump sbt-org later today 👍 |
fe87a32
to
842f6cd
Compare
mmmh getting https://travis-ci.org/47deg/github4s/jobs/276970366#L846 with 0.6.4 and sbt doesn't launch with 0.7.0 |
@BenFradet I think Scala.js
Links that I stumbled on and for anyone else searching: Release notes for sbt |
The travis ci error: |
@suhasgaddam thanks! didn't know about the issue with microsites / 0.13.16 min for 0.6.20 |
b5de641
to
a24d0cf
Compare
project/plugins.sbt
Outdated
addSbtPlugin( | ||
"com.47deg" % "sbt-org-policies" % "0.5.4" exclude ("io.get-coursier", "sbt-coursier")) | ||
"com.47deg" % "sbt-org-policies" % "0.6.4" exclude ("io.get-coursier", "sbt-coursier")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 0.7.0 0.7.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed 😨
4e82e36
to
68dcd6b
Compare
Weirdly enough it seems to compile fine even though However, it fails during the cats-effect tests with https://travis-ci.org/47deg/github4s/jobs/277197841#L2596. Still investigating 😕 |
68dcd6b
to
b5cd021
Compare
@juanpedromoreno fixed! 👍 Regarding releasing a version, do I just need to edit |
Yes, you only need to modify the Are we releasing the Either way, I'd suggest doing it in a different PR, since due to 47degrees/sbt-org-policies#637, the plugin is not running the release task correctly. Hence, we might need to edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, outstanding work.
@juanpedromoreno ok thanks 👍 , I'll open a new PR yes, I agree that 0.16.0 makes more sense btw |
It also migrates from cats
0.9.0
to1.0.0-MF
, among other upgrades and enhancements.