Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make status' id a Long #183

Merged
merged 1 commit into from
Dec 10, 2017
Merged

Make status' id a Long #183

merged 1 commit into from
Dec 10, 2017

Conversation

BenFradet
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #183 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   87.11%   86.95%   -0.17%     
==========================================
  Files          42       42              
  Lines         621      621              
  Branches        5        5              
==========================================
- Hits          541      540       -1     
- Misses         80       81       +1
Impacted Files Coverage Δ
...c/main/scala/github4s/free/domain/Repository.scala 100% <ø> (ø) ⬆️
.../jvm/src/main/scala/github4s/util/URLEncoder.scala 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9452826...5f32d84. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BenFradet BenFradet merged commit 8191fff into master Dec 10, 2017
@BenFradet BenFradet deleted the bf-fix-status branch December 10, 2017 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants