# Make body: Option[String]
#200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can create a PR with `"body": null` if you use the API, or use a tool that uses the API. ```shell curl -X GET https://api.github.com/repos/lloydmeta/gh-test-repo/pulls [ { "url": "https://api.github.com/repos/lloydmeta/gh-test-repo/pulls/3", // snip "body": null, // snip }, { "url": "https://api.github.com/repos/lloydmeta/gh-test-repo/pulls/1", "id": 173714694, "html_url": "lloydmeta/gh-test-repo#1", "diff_url": "https://github.com/lloydmeta/gh-test-repo/pull/1.diff", "patch_url": "https://github.com/lloydmeta/gh-test-repo/pull/1.patch", "issue_url": "https://api.github.com/repos/lloydmeta/gh-test-repo/issues/1", // snip "body": "", ] ```
BenFradet
approved these changes
Mar 10, 2018
| "PullRequests >> List" should "return a right response when a valid repo is provided but not all pull requests have body" in { | ||
| val response = | ||
| Github(accessToken).pullRequests | ||
| .list("lloydmeta", "gh-test-repo", List(PRFilterOpen)) |
There was a problem hiding this comment.
I hope you're not planning on changing this anytime soon 😄
There was a problem hiding this comment.
LOL, yeah, I made that repo just so there would be zero chance of it changing :)
|
@lloydmeta do you need a release? |
|
@BenFradet Yea, a release would be much appreciated. Just for some context, I'm trying to build a tool that would allow me to run Scalafmt on files that aren't currently involved in any recent PRs and submit a PR for formatting. The idea being to unintrusively format a large codebase. I'm filing PRs to github4s as I make progress. |
|
interesting stuff, we'll release 0.18.3 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can create a PR with
"body": nullif you use the API, or use a toolthat uses the API.
This PR makes
body: Option[String]curl -X GET https://api.github.com/repos/lloydmeta/gh-test-repo/pulls [ { "url": "https://api.github.com/repos/lloydmeta/gh-test-repo/pulls/3", // snip "body": null, // snip }, { "url": "https://api.github.com/repos/lloydmeta/gh-test-repo/pulls/1", // snip "body": "", // snip ]