Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the only purpose of doing a major refactoring to replace the free-monad approach in favor of tagless-final (a more convenient pattern), I've been analyzing the pieces that need to be re-implemented and I realized that the parameter
C
in this classHttpClient[C, M[_]]
is completely unused and also forces to propagate it up several layers, affecting even to the way we use this library.This PR removes consequently this unnecessary parameter across the board.
Note: I'm assuming that at some point, we were using it but when discarded the ScalaJS compatibility stopped making sense anymore. Now, it was always resolved as
HttpResponse[String]
.