Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused parameter #327

Merged
merged 6 commits into from
Jan 21, 2020
Merged

Removes unused parameter #327

merged 6 commits into from
Jan 21, 2020

Conversation

rafaparadela
Copy link

@rafaparadela rafaparadela commented Jan 21, 2020

With the only purpose of doing a major refactoring to replace the free-monad approach in favor of tagless-final (a more convenient pattern), I've been analyzing the pieces that need to be re-implemented and I realized that the parameter C in this class HttpClient[C, M[_]] is completely unused and also forces to propagate it up several layers, affecting even to the way we use this library.

This PR removes consequently this unnecessary parameter across the board.

Note: I'm assuming that at some point, we were using it but when discarded the ScalaJS compatibility stopped making sense anymore. Now, it was always resolved as HttpResponse[String].

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f925fd8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #327   +/-   ##
=========================================
  Coverage          ?   87.85%           
=========================================
  Files             ?       37           
  Lines             ?      700           
  Branches          ?        5           
=========================================
  Hits              ?      615           
  Misses            ?       85           
  Partials          ?        0
Impacted Files Coverage Δ
...cala/github4s/HttpRequestBuilderExtensionJVM.scala 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f925fd8...76fb666. Read the comment docs.

@rafaparadela rafaparadela merged commit 86f1f29 into master Jan 21, 2020
@rafaparadela rafaparadela deleted the removes-unused-parameter branch January 21, 2020 06:18
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an artifact of the scalajs implementation iirc, nice to get rid of it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants