-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get the list of teams in an organization. #350
Conversation
…ion, added runtime implicits, added User alg interpretation
… as default param, added headers as default param
…oken as a default parameter
applied some refactoring to have clean layers
# Conflicts: # project/ProjectPlugin.scala
… am-337-ListTeams
… am-337-ListTeams � Conflicts: � github4s/src/main/scala/github4s/Github.scala � github4s/src/main/scala/github4s/modules/GithubAPIs.scala
� Conflicts: � docs/docs/contributing.md � github4s/src/main/scala/github4s/Decoders.scala � github4s/src/main/scala/github4s/Github.scala � github4s/src/main/scala/github4s/algebras/Teams.scala � github4s/src/main/scala/github4s/domain/Team.scala � github4s/src/main/scala/github4s/http/RequestBuilder.scala � github4s/src/main/scala/github4s/interpreters/TeamsInterpreter.scala � github4s/src/main/scala/github4s/modules/GithubAPIs.scala � github4s/src/test/scala/github4s/integration/GHActivitiesSpec.scala � github4s/src/test/scala/github4s/integration/GHAuthSpec.scala � github4s/src/test/scala/github4s/integration/GHGitDataSpec.scala � github4s/src/test/scala/github4s/integration/GHIssuesSpec.scala � github4s/src/test/scala/github4s/integration/GHOrganizationsSpec.scala � github4s/src/test/scala/github4s/integration/GHPullRequestsSpec.scala � github4s/src/test/scala/github4s/integration/GHReposSpec.scala � github4s/src/test/scala/github4s/integration/GHUsersSpec.scala � github4s/src/test/scala/github4s/utils/BaseIntegrationSpec.scala � github4s/src/test/scala/github4s/utils/TestData.scala � project/ProjectPlugin.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
github4s/src/main/scala/github4s/interpreters/TeamsInterpreter.scala
Outdated
Show resolved
Hide resolved
github4s/src/test/scala/github4s/utils/BaseIntegrationSpec.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
- Coverage 93.19% 92.07% -1.12%
==========================================
Files 23 23
Lines 529 505 -24
Branches 2 1 -1
==========================================
- Hits 493 465 -28
- Misses 36 40 +4
Continue to review full report at Codecov.
|
Co-Authored-By: Juan Pedro Moreno <4879373+juanpedromoreno@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 , it might need rebase though 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect to reflect this new API in the docs. Apart from that, LGTM.
This PR solves #337