Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the list of teams in an organization. #350

Merged
merged 63 commits into from
Feb 25, 2020
Merged

Conversation

anamariamv
Copy link
Contributor

This PR solves #337

bond15 and others added 30 commits January 21, 2020 09:57
…ion, added runtime implicits, added User alg interpretation
… as default param, added headers as default param
applied some refactoring to have clean layers
rafaparadela and others added 12 commits February 17, 2020 10:58
# Conflicts:
#	project/ProjectPlugin.scala
… am-337-ListTeams

� Conflicts:
�	github4s/src/main/scala/github4s/Github.scala
�	github4s/src/main/scala/github4s/modules/GithubAPIs.scala
� Conflicts:
�	docs/docs/contributing.md
�	github4s/src/main/scala/github4s/Decoders.scala
�	github4s/src/main/scala/github4s/Github.scala
�	github4s/src/main/scala/github4s/algebras/Teams.scala
�	github4s/src/main/scala/github4s/domain/Team.scala
�	github4s/src/main/scala/github4s/http/RequestBuilder.scala
�	github4s/src/main/scala/github4s/interpreters/TeamsInterpreter.scala
�	github4s/src/main/scala/github4s/modules/GithubAPIs.scala
�	github4s/src/test/scala/github4s/integration/GHActivitiesSpec.scala
�	github4s/src/test/scala/github4s/integration/GHAuthSpec.scala
�	github4s/src/test/scala/github4s/integration/GHGitDataSpec.scala
�	github4s/src/test/scala/github4s/integration/GHIssuesSpec.scala
�	github4s/src/test/scala/github4s/integration/GHOrganizationsSpec.scala
�	github4s/src/test/scala/github4s/integration/GHPullRequestsSpec.scala
�	github4s/src/test/scala/github4s/integration/GHReposSpec.scala
�	github4s/src/test/scala/github4s/integration/GHUsersSpec.scala
�	github4s/src/test/scala/github4s/utils/BaseIntegrationSpec.scala
�	github4s/src/test/scala/github4s/utils/TestData.scala
�	project/ProjectPlugin.scala
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #350 into master will decrease coverage by 1.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   93.19%   92.07%   -1.12%     
==========================================
  Files          23       23              
  Lines         529      505      -24     
  Branches        2        1       -1     
==========================================
- Hits          493      465      -28     
- Misses         36       40       +4
Impacted Files Coverage Δ
github4s/src/main/scala/github4s/Github.scala 100% <ø> (ø) ⬆️
...scala/github4s/interpreters/TeamsInterpreter.scala 100% <ø> (ø) ⬆️
github4s/src/main/scala/github4s/Decoders.scala 90.55% <100%> (-0.88%) ⬇️
.../src/main/scala/github4s/http/RequestBuilder.scala 100% <100%> (ø) ⬆️
...hub4s/src/main/scala/github4s/GithubIOSyntax.scala 0% <0%> (-66.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ba652...d063bd0. Read the comment docs.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , it might need rebase though 😁

Copy link
Contributor

@bond15 bond15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

github4s/src/main/scala/github4s/algebras/Teams.scala Outdated Show resolved Hide resolved
github4s/src/main/scala/github4s/Decoders.scala Outdated Show resolved Hide resolved
Copy link

@rafaparadela rafaparadela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to reflect this new API in the docs. Apart from that, LGTM.

@rafaparadela rafaparadela merged commit ecb14cd into master Feb 25, 2020
@rafaparadela rafaparadela deleted the am-337-ListTeams branch February 25, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants